Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ Bug reports ➜ New 'trigger' fixes are worse..
New 'trigger' fixes are worse..

It is now over 60 days since the last post. This thread is closed.     Refresh page

Pages: 1 2  

Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Thu 31 Oct 2002 02:54 AM (UTC)

Amended on Thu 31 Oct 2002 03:03 AM (UTC) by Shadowfyr

Message
The following are a set of lines from playing and appropriate comments:

-------------------------------------------
You feel older and wiser all of a sudden! <-- should trigger in a plugin, but fails to match.
[Ww-Hb-Mb-Bc-Sp-Sh-Ar-In-Sg-Sl-Pn] <-- Timer generated. The Ww 'should' have been set in the prior trigger, but since it didn't happen...
Your Godshield slowly loses energy and ebbs into non-existence. <-- normal line, no coloring
xxXX Godshield XXxx <-- generated by trigger for previous line.
[Ww-Hb-Mb-Bc-Sp-Sh-Ar-In-Sg-Sl-Pn] <-- Timer again
summon animal <-- command
You begin concentrating. <-- trigger colored.
Thu Oct 31 06:00:46 2002 Ex = 8479814> <-- Normal
[Ww-Hb-Mb-Bc-Sp-Sh-Ar-In-Sg-Sl-Pn] <-- Timer
HP: [1303/1303] CONC: [2552/2581] <-- Hitbar plugin
You have finished concentrating on the skill. <-- This is a color trigger, no match, so it ends up Gray?? (the last trigger used that as last color).
You summon a familiar. <-- Normal
[Ww-Hb-Mb-Bc-Sp-Sh-Ar-In-Sg-Sl-Pn] <-- Timer
godshield <-- command
You place your hand on your chest and start to pray. <-- Normal
Thu Oct 31 06:01:04 2002 Ex = 8479814> <-- Normal
[gossip]: Fyxen nuzzles sparhawk gratefully. <-- Normal
[Ww-Hb-Mb-Bc-Sp-Sh-Ar-In-Sg-Sl-Pn] <-- Timer
Your prayer is answered and you sense Gods hand surround you, creating a <-- Normal
shield against your foe. <-- Normal
xxXX Godshield Up XXxx <-- Generated by trigger from last line.
-------------------------------------------

Later>

-------------------------------------------
You missed Giant. <-- color triggered pinkish red
You missed Giant. <-- color triggered pinkish red
You smash Giant's body with a great blow. <-- color triggered light green
HP: [1303/1303] CONC: [2581/2581] OPPONENT: blood flowing freely <-- generated by plugin
Giant devastated your entire being with the force of the blow. <-- colored gray (no match)
Giant devastated your entire being with the force of the blow. <-- trigger colored orange
Giant devastated your entire being with the force of the blow. <-- trigger colored orange
Giant missed you. <-- trigger colored green
Giant pulverized your body into an unrecognizable mess. <-- trigger colored red
You have finished concentrating on the spell. <-- same as above, but this time colored peach.
You call a lightning to strike Giant. <-- normal line, no trigger
-------------------------------------------

While your fix does correctly help triggers to match that previously failed do to breaks caused by commands, it now fails on others where the line follows any world.send, tell, colourtell, coloursend, etc. This is far worse than the prior situtation imho, since it fails nearly 10 times as often.
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #1 on Thu 31 Oct 2002 05:09 AM (UTC)
Message
I can't reproduce that, so there must be something in your setup that is different from mine.

I am testing using a regular expression trigger to match on a partial line, colouring the matching words to confirm the match.

I have tried sending to myself such a line, directly after a command, timer fire, and world.tell etc. and in each case the trigger fires.

Perhaps email me your world file, tell me which trigger concerns you and what happens immediately before, and I'll try to reproduce it here.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #2 on Thu 31 Oct 2002 08:13 PM (UTC)
Message
It may be tied to plugins. All failures happen immediately following a line generated by my Hitbar plugin. I can't be sure if it is linked indirectly to the other plugin that generates the [Ww-Hb-Mb... line, but the only specific thing I can think of is that it is gray due to the Hitbar line terminating with world.colournote "#C0C0C0","Black"," ". This is to prevent lines like the prompt which don't correctly set the color before display (it assumes I believe that the color has been reset to default by the prior line), show up in the correct color.

So the problem is probably with plugins and would not show up with just normal world file based color triggers. I'll email you a zip of all the relate files I am using.
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #3 on Fri 01 Nov 2002 12:30 AM (UTC)
Message
Hmm. I sent you the files.. However on consideration you might over look them, since the email address may be set to 'selliot@redrivernet.com' and The name in the plugins is the japanese form of my screen name 'Kagehi'. lol
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #4 on Fri 01 Nov 2002 01:10 AM (UTC)

Amended on Fri 01 Nov 2002 01:11 AM (UTC) by Nick Gammon

Message
I got them thanks.

What would help would be if you could reproduce it in a small test case.

ie. take an empty world and just add in enough triggers (say, one) to reproduce it. Running traces on large quantities of triggers and plugins can obscure the real problem with a lot of code that isn't making any difference.

Also read my post to Faolong, see if you can find out whether it mis-identifies output lines as note lines or vice-versa.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #5 on Fri 01 Nov 2002 01:37 AM (UTC)
Message
Hmm. Doesn't look like the same problem, but it may be related. As for narrowing the triggers..

The problem only happens 'if' a color trigger immediately follows the line generated by the hitbar plugin, so you could simple disable everything except say this one:

<triggers>
<trigger
custom_colour="2"
enabled="y"
match="*You have finished c*"
sequence="25"
>
</trigger>
</triggers>

and the hitbar plugin. Then these lines 'should' cause it:


HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.

A quick test using my echo proxy Phantom, only the above trigger and the hitbar plugin does (italics are the 'commands' being sent and echoed back by the proxy as new lines):

HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #6 on Fri 01 Nov 2002 01:38 AM (UTC)

Amended on Fri 01 Nov 2002 01:43 AM (UTC) by Shadowfyr

Message
Hmm. Doesn't look like the same problem, but it may be related. With this single trigger:

<triggers>
<trigger
custom_colour="2"
enabled="y"
match="*You have finished c*"
sequence="25"
>
</trigger>
</triggers>

and the hitbar plugin, these lines 'should' cause it:


HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.

A quick test using my echo proxy program Phantom and using only the above trigger and the hitbar plugin produces the following (bold lines are the 'commands' being sent and echoed back by the proxy as new lines):

HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Colored
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell.
HP: [465/465] CONC: [1560/1560]
You have finished concentrating on the spell. <-- Fail

NOTE: I am using the hitbar plugin with the 'hitbar:% inc3' command to set the mode. The default mode handles coloring using a less complex method, but seems to produce the same identical results. Also, I have confirmed that it is a match failure. i.e. No coloring, no sub calls, nothing when they fail.
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #7 on Fri 01 Nov 2002 02:24 AM (UTC)
Message
Do the failing lines show as note or output lines if you move the mouse over them with "show line info" enabled?

Also, did version 3.28 work for you, or 3.27?
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #8 on Fri 01 Nov 2002 02:27 AM (UTC)
Message
It's OK, I reproduced it. I had rather foolishly been sending two linefeeds, the second one reset the problem. Now to investigate.

BTW - it marks the problem line as a note line.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #9 on Fri 01 Nov 2002 02:44 AM (UTC)
Message
OK, I've got it. No wonder it was hard to find.

The problem occurs if both lines appear in the same *packet* from the MUD. When I test slowly it isn't there. I have to send both lines together, then the "note" flag from the first line runs onto the second line, and the trigger isn't tested.

I've fixed that.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #10 on Fri 01 Nov 2002 02:47 AM (UTC)
Message
Great! It seemed an odd thing to crop up. lol
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #11 on Fri 01 Nov 2002 02:56 AM (UTC)
Message
I took out one line which forced every line to be treated as the same type as the *last* character received. This covered up the other problem. However the line I removed was causing a problem, because a line like this:

<blah blah MUD prompt> my_command

... was treated as a command line because the last thing on the line was a command, thus the trigger wouldn't fire on it.

However the check for setting the line type was done on a packet basis, not a newline basis, that is how it slipped through.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #12 on Fri 01 Nov 2002 03:01 AM (UTC)
Message
Yeah.. I can see that. Oops.. I was just saying it seemed a real odd glitch prior to knowing the source of it. ;)
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #13 on Fri 01 Nov 2002 03:11 AM (UTC)
Message
OK, it is ready to download. Hopefully your problems are solved.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Shadowfyr   USA  (1,791 posts)  Bio
Date Reply #14 on Fri 01 Nov 2002 03:21 AM (UTC)

Amended on Fri 01 Nov 2002 03:29 AM (UTC) by Shadowfyr

Message
Hmm.. Nope.. It is still doing the same thing.... Umm. I got it from the FTP one. I'll try the HTTP site. :p
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

45,741 views.

This is page 1, subject is 2 pages long: 1 2  [Next page]

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum

[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

Home