Gammon Forum : SMAUG : SMAUG coding : obj_to_room problem... infinite loops

Entire forum ➜ SMAUG ➜ SMAUG coding ➜ obj_to_room problem... infinite loops

obj_to_room problem... infinite loops

It is now over 60 days since the last post. This thread is closed. Refresh page

Pages: 1 2

Posted by Samson USA (683 posts) Bio

Date Tue 11 May 2004 12:52 AM (UTC)

Message

I'm having a problem I can't quite pin down. Against many peoples' better judgement I've started down a C++ conversion of the AFKMud codebase. So far that's gone pretty well, even though it's still in the earlier stages. But just today I noticed a pretty serious problem. When doing a hotboot, reloading the object files that were saved prior to the boot creates an infinite loop as it boots up. I believe I've traced it to the function that loads the objects ( logs stop there and go no farther ). I think the obj_to_room conversion is to blame, and as I was examining it, I began to wonder. Just WTF does this thing do anyway? Why does obj_to_room return an OBJ_DATA pointer? It worked perfectly before the conversion, but obviously it's now now. So maybe I'm doing something wrong?

Alternately, maybe I just don't grasp how the obj_to_room code works, so I'm posting what I have here, including the obj_group function as well since that seems to play a key part in what's going on and maybe someone can spot what I've done wrong.

What calls this stuff in the hotboot code:


         obj_from_char( tobj );
    tobj = obj_to_room( tobj, room, supermob );

The replacement for the above is indicated below:


void read_obj_file( char *dirname, char *filename )
{
   room_index *room;
   FILE *fp;
   char fname[256];
   int vnum;

   vnum = atoi( filename );
   snprintf( fname, 256, "%s%s", dirname, filename );

   if( !( room = get_room_index( vnum ) ) )
   {
	bug( "read_obj_file: ARGH! Missing room index for %d!", vnum );
      unlink( fname );
	return;
   }
   
   if ( ( fp = fopen( fname, "r" ) ) != NULL )
   {
	sh_int iNest;
	bool found;
	obj_data *tobj, *tobj_next;

	rset_supermob( room );
      for ( iNest = 0; iNest < MAX_NEST; iNest++ )
   rgObjNest[iNest] = NULL;

	found = true;
	for(;; )
	{
    char letter;
    char *word;

    letter = fread_letter( fp );
    if( letter == '*' )
    {
  fread_to_eol( fp );
  continue;
    }

    if( letter != '#' )
    {
  bug( "%s", "read_obj_file: # not found." );
  break;
    }

    word = fread_word( fp );
    if( !str_cmp( word, "OBJECT" ) )	/* Objects */
  fread_obj( supermob, fp, OS_CARRY );
    else if( !str_cmp( word, "END" ) ) /* Done */
  break;
    else
    {
  bug( "read_obj_file: bad section: %s", word );
  break;
    }
	}
	FCLOSE( fp );
      unlink( fname );
	for( tobj = supermob->first_carrying; tobj; tobj = tobj_next )
	{
    tobj_next = tobj->next_content;
    if( tobj->HAS_FLAG( ITEM_ONMAP ) )
    {
  supermob->SET_ACT_FLAG( ACT_ONMAP );
  supermob->map = tobj->map;
  supermob->mx = tobj->mx;
  supermob->my = tobj->my;
    }
           tobj->from_char(); <---------- REPLACEMENT
    tobj = tobj->to_room( room, supermob ); <------------ REPLACEMENT
    supermob->REMOVE_ACT_FLAG( ACT_ONMAP );
    supermob->map = -1;
    supermob->mx = -1;
    supermob->my = -1;
	}
	release_supermob();
   }
   else
	log_string( "Cannot open obj file" );

   return;
}