Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ SMAUG ➜ Running the server ➜ Spell bug, iceshield

Spell bug, iceshield

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Zeno   USA  (2,871 posts)  Bio
Date Wed 11 May 2005 11:31 PM (UTC)

Amended on Wed 11 May 2005 11:41 PM (UTC) by Zeno

Message
#SKILL 
 Name         iceshield~ 
 Type         Spell 
 Info         0 
 Flags        0 
 Target       2 
 Minpos       112 
 Slot         221 
 Mana         85 
 Rounds       12 
 Code         spell_smaug 
 Dammsg       ~ 
 Wearoff      The hail of ice rapidly melts and evaporates into nothingness.~ 
 Hitchar      A glistening hail of ice encompasses $N.~ 
 Hitvict      A glistening hail of ice encompasses you.~ 
 Hitroom      A glistening hail of ice encompasses $N.~ 
 Affect       '(l*4)+8' 26 'iceshield' 28 
 Minlevel     101 
 End 


When something with this affect on it is attacked, this bug comes up:
Log: [*****] BUG: spell_smaug: Called with a null skill for sn -1


Does anyone see anything wrong with the skill or what is wrong?

[EDIT] Turns out the spell calls iceshard. Does anyone see where it shows that?

Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top

Posted by Gatewaysysop2   USA  (146 posts)  Bio
Date Reply #1 on Thu 12 May 2005 01:59 AM (UTC)
Message
Hrmm. Just tried this repeatedly, can't seem to reproduce it. :(

"The world of men is dreaming, it has gone mad in its sleep, and a snake is strangling it, but it can't wake up." -D.H. Lawrence
Top

Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #2 on Thu 12 May 2005 03:14 AM (UTC)
Message
Yeah I know. This is my mud where I took out a lot of skills. I had to put back in iceshard.

Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top

Posted by Samson   USA  (683 posts)  Bio
Date Reply #3 on Fri 20 May 2005 12:30 PM (UTC)
Message

   if( vic->has_aflag( AFF_ICESHIELD ) && !ch->has_aflag( AFF_ICESHIELD ) )
      retcode = spell_smaug( skill_lookup( "iceshard" ), vic->level, vic, ch );


You should have something like that in your fight.c file. If the target has an iceshield, and is hit, the reflected damage is done by the iceshard spell with the above code.
Top

Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #4 on Fri 20 May 2005 06:18 PM (UTC)
Message
Ahhh. Tch, hardcoded eh? *mutter* Thanks though.

Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top

Posted by Dralnu   USA  (277 posts)  Bio
Date Reply #5 on Wed 15 Jun 2005 12:06 AM (UTC)
Message
Thats a problem with SMAUG. All the spells are hardcoded into the system, which makes it a pain to alter them...
Top

Posted by Conner   USA  (381 posts)  Bio
Date Reply #6 on Wed 15 Jun 2005 12:38 AM (UTC)
Message
While a bunch of the spells are coded into the system, not all of them are. Many of the spells are just spell_smaug rather than spell_<coded spell name>.

-=Conner=-
--
Come test your mettle in the Land of Legends at telnet://tcdbbs.zapto.org:4000
or, for a little family oriented medieval fun, come join us at The Castle's Dungeon BBS at telnet://tcdbbs.zapto.org
or, if you just want information about either, check our web page at http://tcdbbs.zapto.org
Top

Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #7 on Wed 15 Jun 2005 01:04 AM (UTC)
Message
Well I meant hard coded as in the effect calling iceshard. They aren't hard to alter, just issues like this that'll arise.

Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top

Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #8 on Wed 15 Jun 2005 02:56 AM (UTC)
Message
Hard-coded spells are the least of your worries, I've found. It seems that almost everything is hard-coded. There can be lots of little problems that crop up because of that in lots of unexpected places in the code. This is a good example of one of them.

David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top

Posted by Conner   USA  (381 posts)  Bio
Date Reply #9 on Wed 15 Jun 2005 03:07 AM (UTC)
Message
Nah, that's what I mean, a bunch of them are not hard-coded, even effects, they're entirely editable/creatable online using the sset and slookup commands with the help category of smaugspells... on the other hand, yes, this one is hard-coded and is just one of the many things that are hard-coded and can give you all sorts of headaches along the way. But it's not as bad as some would have you believe either.

-=Conner=-
--
Come test your mettle in the Land of Legends at telnet://tcdbbs.zapto.org:4000
or, for a little family oriented medieval fun, come join us at The Castle's Dungeon BBS at telnet://tcdbbs.zapto.org
or, if you just want information about either, check our web page at http://tcdbbs.zapto.org
Top

Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #10 on Wed 15 Jun 2005 05:06 AM (UTC)
Message
I wasn't talking about skills and spells. I was talking about all the hard-coded, hidden dependencies in SMAUG. This iceshard thing is an example of a hidden, hard-coded dependency, but there are many more. It's to be expected; the codebase grew from accretion and it seems that nobody ever took the time to go in and clean up the house.

David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


27,640 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.